[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150827.221643.2144480812551172735.davem@davemloft.net>
Date: Thu, 27 Aug 2015 22:16:43 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: dsa@...ulusnetworks.com
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: FIB tracepoints
From: David Ahern <dsa@...ulusnetworks.com>
Date: Thu, 27 Aug 2015 22:07:30 -0700
> On 8/27/15 10:05 PM, David Miller wrote:
>> From: David Ahern <dsa@...ulusnetworks.com>
>> Date: Thu, 27 Aug 2015 21:59:32 -0700
>>
>>> + __array( __u8, src, 4 )
>>> + __array( __u8, dst, 4 )
>> ...
>>> + __array( __u8, src, 4 )
>>
>> Maybe there is something I don't understand about tracing, but why not
>> use __u32? If endianness types are the issue, just force cast it as
>> needed.
>>
>> Using a memcpy() on a 4-byte array is kinda excessive.
>>
>
> Silly trick need to use %pI4. ie., printing the addresses as strings
> vs. hex.
%pI4 doesn't care what kind of pointer you give it, &__entry->src will
work just fine if you used __u32.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists