netdev - Re: [PATCH net-next] net: FIB tracepoints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55DFF28B.4050302@cumulusnetworks.com>
Date:	Thu, 27 Aug 2015 22:32:59 -0700
From:	David Ahern <dsa@...ulusnetworks.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: FIB tracepoints

On 8/27/15 10:17 PM, David Miller wrote:
> From: David Ahern <dsa@...ulusnetworks.com>
> Date: Thu, 27 Aug 2015 22:12:01 -0700
>
>> perhaps an example helps:
>>
>> swapper 0 [000] 406.447548: fib:fib_table_lookup: table 255 oif 0 iif
>> 0 src 0.0.0.0 dst 2.1.1.2 tos 0 scope 0 flags 0
>>
>> If src and dst are u32's then they print as either 0x%x or %d which is
>> not intuitive. I added support to perf for the following printk
>> formats with 3d199b5be53:
>   ...
>
> The following had better work:
>
> 	__u32 addr;
> 	printk("%pI4\n", &addr);
>
> We do it everywhere in the networking code.
>
> I don't know why you think it is required to use an array.
>

TP_printk is not printk. See my other response.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html