netdev - Re: [PATCH v5 net-next 5/8] geneve: Add support to collect tunnel metadata.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Aug 2015 12:22:13 +0200
From:	Thomas Graf <tgraf@...g.ch>
To:	Pravin Shelar <pshelar@...ira.com>
Cc:	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v5 net-next 5/8] geneve: Add support to collect tunnel
 metadata.

On 08/27/15 at 02:29pm, Pravin Shelar wrote:
> On Thu, Aug 27, 2015 at 2:18 AM, Thomas Graf <tgraf@...g.ch> wrote:
> > It is slightly non obvious that introducing an error condition above
> > this and before udp_tun_rx_dst() would introduce a memory leak. Other
> > than this looks great now.
> >
> I can not move this into if condition block since skb-scrub-packet
> drops skb dst entry.

I understand, VXLAN does the same. A comment would help though.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html