netdev - Re: [PATCH net-next 7/8] net: thunderx: Support for upto 96 queues for a VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150828.221049.256686243264204039.davem@davemloft.net>
Date:	Fri, 28 Aug 2015 22:10:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	klimov.linux@...il.com
Cc:	aleksey.makarov@...iga.com, netdev@...r.kernel.org,
	rric@...nel.org, david.daney@...ium.com,
	Sunil.Goutham@...iumnetworks.com,
	aleksey.makarov@...iumnetworks.com, linux-kernel@...r.kernel.org,
	rrichter@...ium.com, robert.richter@...iumnetworks.com,
	sgoutham@...ium.com, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next 7/8] net: thunderx: Support for upto 96 queues
 for a VF

From: Alexey Klimov <klimov.linux@...il.com>
Date: Sat, 29 Aug 2015 04:45:03 +0300

>> @@ -717,9 +833,24 @@ static void nic_unregister_interrupts(struct nicpf *nic)
>>         nic_disable_msix(nic);
>>  }
>>
>> +static int nic_num_sqs_en(struct nicpf *nic, int vf_en)
>> +{
>> +       int pos = 0, sqs_per_vf = MAX_SQS_PER_VF_SINGLE_NODE;
> 
> Please check if you really need to initialize 'pos' by zero here.

Please do _NOT_ quote hundreds of lines of code only to give feedback
on one particular hunk.

Quote _ONLY_ the exact context required, nothing more.

Everyone has to scroll through all of this unrelated crap you quoted,
and that makes more work for everyone.

Think particularly of _ME_ who has to be aware of what's going on in
every discussion thread for every patch that gets posted to this list.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html