netdev - Re: [PATCH net v3] bonding: fix bond_poll_controller bh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Aug 2015 22:26:45 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	razor@...ckwall.org
Cc:	netdev@...r.kernel.org, 13806511171@....com,
	shemminger@...ux-foundation.org, maheshb@...gle.com,
	j.vosburgh@...il.com, vfalico@...il.com, gospo@...ulusnetworks.com,
	nikolay@...ulusnetworks.com
Subject: Re: [PATCH net v3] bonding: fix bond_poll_controller bh_enable
 warning

From: Nikolay Aleksandrov <razor@...ckwall.org>
Date: Fri, 28 Aug 2015 15:05:32 -0700

> From: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> 
> The problem is rcu_read_unlock_bh() which triggers a warning when irqs are
> disabled. ndo_poll_controller should run with irqs disabled always so we
> can drop the rcu_read_lock_bh.
 ...
> Fixes: 616f45416ca0 ("bonding: implement bond_poll_controller()")
> Signed-off-by: Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
> ---
> v3: After Dave made it clear that poll_controller should always be called
> with interrupts disabled we can simply drop the rcu bh lock.

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html