netdev - Re: [PATCH, net-next] r8169: Deny functions membet of array rtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150829112630.GA8873@electric-eye.fr.zoreil.com>
Date:	Sat, 29 Aug 2015 13:26:30 +0200
From:	Francois Romieu <romieu@...zoreil.com>
To:	Corcodel Marian <corcodel.marian@...il.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH, net-next] r8169: Deny functions membet of array rtl_work

Corcodel Marian <corcodel.marian@...il.com> :
> Deny functions member of array rtl_work to run when link  is
> ok.After rtl8169_init_phy exist 10 sec  timeout.On many  cases link is ok and
> no need to destroy all work.

I won't figure what happens outside of the "many cases" statement.

rtl_reset_work is a hard reset. It isn't supposed to go shopping just
because the link seems to be established. Moreover you don't explain why
you need to vandalize rtl_phy_work (unrelated to any 10 sec timeout).

As usual nobody knows how it was tested (suspend/resume, change location
and port, etc.).

Please don't send me private only e-mail.

-- 
Ueimor
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html