netdev - Re: [PATCH] geneve: Use GRO cells infrastructure.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150829.134537.1296061605473806203.davem@davemloft.net>
Date:	Sat, 29 Aug 2015 13:45:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jesse@...ira.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] geneve: Use GRO cells infrastructure.

From: Jesse Gross <jesse@...ira.com>
Date: Fri, 28 Aug 2015 16:54:40 -0700

> Geneve can benefit from GRO at the device level in a manner similar
> to other tunnels, especially as hardware offloads are still emerging.
> 
> After this patch, aggregated frames are seen on the tunnel interface.
> Single stream throughput nearly doubles in ideal circumstances (on
> old hardware).
> 
> Signed-off-by: Jesse Gross <jesse@...ira.com>

Applied, thanks Jesse.

While reviewing this I noticed that the gro cells code goes through all
of the trouble of allocating full per-cpu objects to manage the packet
queuing and processing, but then it uses a full spinlock for protection.

It ought to be sufficient to just block out BH processing or, at worst,
local cpu interrupts, to protect the individual per-cpu cells.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html