netdev - IPv6 xfrm GSO fragmentation bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150830082432.GA25588@gondor.apana.org.au>
Date:	Sun, 30 Aug 2015 16:24:32 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Steffen Klassert <steffen.klassert@...unet.com>,
	netdev@...r.kernel.org
Subject: IPv6 xfrm GSO fragmentation bug

Hi Steffen:

I received a bug report regarding poor IPComp performance over
IPv6:

	https://bugzilla.redhat.com/show_bug.cgi?id=1257952

It appears to have been caused by

commit dd767856a36e00b631d65ebc4bb81b19915532d6
Author: Steffen Klassert <steffen.klassert@...unet.com>
Date:   Tue Oct 11 01:44:30 2011 +0000

    xfrm6: Don't call icmpv6_send on local error

which addded an MTU check without a GSO override.

Fixing it obviously isn't difficult, but I am wondering why I
can't find a corresponding patch for IPv4.  Do we need that check
to be present in xfrm6_output at all? If we do why isn't it needed
for IPv4 as well?

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html