netdev - Re: [PATCH net-next v2 0/4] tcp: receive-side per route dctcp handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150831.123416.266144212097794732.davem@davemloft.net>
Date:	Mon, 31 Aug 2015 12:34:16 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	fw@...len.de, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/4] tcp: receive-side per route dctcp
 handling

From: Daniel Borkmann <daniel@...earbox.net>
Date: Mon, 31 Aug 2015 15:58:43 +0200

> Original cover letter:
> 
>   Currently, the following case doesn't use DCTCP, even if it should:
> 
>     - responder has f.e. cubic as system wide default
>     - 'ip route congctl dctcp $src' was set
> 
>   Then, DCTCP is NOT used if a DCTCP sender attempts to connect from a
>   host in the $src range: ECT(0) is set, but listen_sk is not dctcp, so
>   we fail the INET_ECN_is_not_ect sanity check.
> 
>   We also have to examine the dst used for the SYN/ACK reply to make
>   this case work.
> 
>   In order to minimize additional cost, store the 'ecn is must have'
>   information is the dst_features field.
> 
>   The set targets -next instead of -net since this doesn't seem to be a
>   serious bug and to give the change more soak time until it hits linus
>   tree.
> 
> v1 -> v2:
>  - Addressed Dave's feedback, not exposing any bits to user space
>  - Added patch 3 to reject incorrect configurations
>  - Rest as is, rebased and retested

Series applied, thanks Daniel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html