[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20150830.215603.1010137816632495971.davem@davemloft.net>
Date: Sun, 30 Aug 2015 21:56:03 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: chamaken@...il.com
Cc: netdev@...r.kernel.org, daniel@...earbox.net, fw@...len.de
Subject: Re: [PATCH net] netlink: rx mmap: fix POLLIN condition
From: Ken-ichirou MATSUZAWA <chamaken@...il.com>
Date: Mon, 31 Aug 2015 07:54:49 +0900
> Poll() returns immediately after setting the kernel current frame
> (ring->head) to SKIP from user space even though there is no new
> frame. And in a case of all frames is VALID, user space program
> unintensionally sets (only) kernel current frame to UNUSED, then
> calls poll(), it will not return immediately even though there are
> VALID frames.
>
> To avoid situations like above, I think we need to scan all frames
> to find VALID frames at poll() like netlink_alloc_skb(),
> netlink_forward_ring() finding an UNUSED frame at skb allocation.
>
> Signed-off-by: Ken-ichirou MATSUZAWA <chamas@...dion.ne.jp>
Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists