netdev - Re: [PATCH net-next] net: Remove VRF change to udp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150831.124410.99199729741650263.davem@davemloft.net>
Date:	Mon, 31 Aug 2015 12:44:10 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	dsa@...ulusnetworks.com
Cc:	netdev@...r.kernel.org, shm@...ulusnetworks.com,
	tom@...bertland.com
Subject: Re: [PATCH net-next] net: Remove VRF change to udp_sendmsg

From: David Ahern <dsa@...ulusnetworks.com>
Date: Mon, 31 Aug 2015 09:29:40 -0700

> Remove the VRF change in udp_sendmsg to set the source address. The VRF
> driver already has access to the packet on the TX path via the dst. It
> can be used to update the source address in the header.
> 
> Update function based on OVS.
> 
> Cc: Tom Herbert <tom@...bertland.com>
> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>

This is worse.

You have the source address in the VRF driver's output routine in
fl4.saddr, just use it as-is.

You're adding even more route lookups, at least the existing code
just walks the device address less which is often cheaper than
a full-blown route lookup.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html