netdev - Re: ss format bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150831162316.5e1a9b9e@urahara>
Date:	Mon, 31 Aug 2015 16:23:16 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Mike Saal <msaal@...afe.com>
Cc:	netdev@...r.kernel.org
Subject: Re: ss format bug

On Wed, 26 Aug 2015 11:59:17 -0400
Mike Saal <msaal@...afe.com> wrote:

> Hi:
> 
> I found a formatting bug in the 4.1.1 ss command. The following line was 
> incorrectly output due to passing a negative length to printf() when 
> displaying the local address. In this instance hostapd does a "bind to 
> device" on cdreth0 and then does a udp "in address any" port 67 bind. 
> Please note the whitespace between the '*' and ' %cdreth0:67'
> 
>     'udp UNCONN 0 0 ** %cdreth0:67* *:* users:(("hostapd",pid=19241,fd=5))'
> 
> Attached is my patch for the bug fix, it might be prudent to add more 
> guard code looking for negative length format codes.
> 
> Sincerely, Mike


I think the root cause of this is actually down in the main program
where it is computing addr_width. It is not accounting for the size correctly,
or maybe your case just occurs if screen is too narrow to fit the full width.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html