netdev - Re: [PATCH 1/2] net: Remove ndo_xmit_flush netdev operation, use signalling instead.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150901.000051.2053259950492309439.davem@davemloft.net>
Date:	Tue, 01 Sep 2015 00:00:51 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Yanjun.Zhu@...driver.com
Cc:	netdev@...r.kernel.org, therbert@...gle.com, jhs@...atatu.com,
	hannes@...essinduktion.org, edumazet@...gle.com,
	jeffrey.t.kirsher@...el.com, rusty@...tcorp.com.au,
	dborkman@...hat.com, brouer@...hat.com
Subject: Re: [PATCH 1/2] net: Remove ndo_xmit_flush netdev operation, use
 signalling instead.

From: yzhu1 <Yanjun.Zhu@...driver.com>
Date: Tue, 1 Sep 2015 14:46:38 +0800

> After I applied this patch, the skb->xmit_more is not always zero.

There have been thousands upon thousands of commits since that
change.

You should be testing the tree as it currently stands, to see
if xmit_more behaves correctly or not.

If xmit_more were incorrectly set to 1 in the current tree, it
would stall the TX queue of the networking device and we would
be seeing lots of reports of this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html