netdev - Re: [PATCH net-next] net: Make table id type u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55E5F0FA.4080909@cumulusnetworks.com>
Date:	Tue, 1 Sep 2015 12:39:54 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: Make table id type u32

On 9/1/15 12:39 PM, Nikolay Aleksandrov wrote:
>
>> On Sep 1, 2015, at 11:25 AM, David Ahern <dsa@...ulusnetworks.com> wrote:
>>
>> for net-next. Forgot to add to subject line. (Thanks, Roopa, for the reminder.)
>>
>> On 9/1/15 12:18 PM, David Ahern wrote:
>>> A number of VRF patches used 'int' for table id. It should be u32 to be
>>> consistent with the rest of the stack.
>>>
>>> Fixes:
>>> 4e3c89920cd3a ("net: Introduce VRF related flags and helpers")
>>> 15be405eb2ea9 ("net: Add inet_addr lookup by table")
>>> 30bbaa1950055 ("net: Fix up inet_addr_type checks")
>>> 021dd3b8a142d ("net: Add routes to the table associated with the device")
>>> dc028da54ed35 ("inet: Move VRF table lookup to inlined function")
>>>
>>> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
>>> ---
>>>   include/net/route.h      |  2 +-
>>>   include/net/vrf.h        | 24 ++++++++++++------------
>>>   net/ipv4/af_inet.c       |  2 +-
>>>   net/ipv4/fib_frontend.c  | 10 +++++-----
>>>   net/ipv4/fib_semantics.c |  2 +-
>>>   5 files changed, 20 insertions(+), 20 deletions(-)
> <<snip>>
>
> Should the fib_table_lookup tracepoint be updated as well ? It seems to be using
> int for tb_id even though it’s a u32 in struct fib_table.
>

yes. good catch.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html