netdev - Re: [PATCH net] sctp: support global vtag assochash and per endpoint s(d)port assochash table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_cLgw3xnnT2_ENZgaFTWncpoKNF2bazBWuX152ZSLUG4w@mail.gmail.com>
Date:	Wed, 2 Sep 2015 04:11:44 +0800
From:	lucien xin <lucien.xin@...il.com>
To:	Vlad Yasevich <vyasevic@...hat.com>
Cc:	network dev <netdev@...r.kernel.org>,
	Marcelo Ricardo Leitner <mleitner@...hat.com>,
	daniel@...earbox.net, davem <davem@...emloft.net>
Subject: Re: [PATCH net] sctp: support global vtag assochash and per endpoint
 s(d)port assochash table

>
> In addition to what David said and looking at it from a different angle... 256 buckets
> may not be enough for someone with a single endpoint and alot of associations.  You
> will still hit a long chain on INIT and COOKIE-ECHO chunks.
>
> Switching to using rhashtable for association hash would be very nice.
>
good idea, I will think about it.

> Also, see if you can split this into 2 parts, one that does vtag hash and
> the other is refactoring.  It would make it much easier to review.
>
I tried, it's kind of hard, cause i do not add the vtag hashtable, but
change the
original hashtable to vtag hashtable, which make sendmsg lost its hashtable.
I have to add another one for per endpoint.
anyway, I will try to split it again, thanks.

> -vlad
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html