netdev - Re: [net-next PATCH 0/4] fixup IFF_NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdWEoCrFuVmFUUWVv8dhV_WHtq9mzx_emKBUYwTYUhDniw@mail.gmail.com>
Date:	Tue, 1 Sep 2015 09:52:41 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	David Miller <davem@...emloft.net>
Cc:	Phil Sutter <phil@....cc>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Eric Dumazet <eric.dumazet@...il.com>, brouer@...hat.com
Subject: Re: [net-next PATCH 0/4] fixup IFF_NO_QUEUE conversion

On Fri, Aug 28, 2015 at 2:15 AM, David Miller <davem@...emloft.net> wrote:
>> This series serves two purposes:
>>
>> On one hand it fixes a quite embarrassing bug around the warning I added for
>> drivers still setting tx_queue_len = 0 to achieve noqueue operation. It turned
>> out to be quite useless as due to using alloc_netdev(), many in-kernel drivers
>> fell into the trap by accident, as well. Instead this place serves pretty well
>> as a sanitizing point to set IFF_NO_QUEUE for drivers not initializing
>> tx_queue_len, which in turn allows to drop all special treatment of the latter
>> being zero since that can not happen anymore without IFF_NO_QUEUE being set.
>>
>> On the other hand, it provides a better solution for Eric Dumazet's concern
>> regarding how to assign noqueue to an interface which does not default to it
>> already. In order to make this possible, noqueue is being registered so users
>> can 'tc qd add dev eth0 root noqueue'. In addition, it resolves the ugly
>> situation of 'tc qd show' not showing noqueue. Finally, the former changes
>> allow for some code cleanup.
>
> Seems reasonable, series applied, thanks Phil.

Thanks, the warning is gone.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html