netdev - Re: [PATCH net-next v2] net: Add table id from route lookup to route response

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55E75D45.2090105@cumulusnetworks.com>
Date:	Wed, 2 Sep 2015 14:34:13 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Thomas Graf <tgraf@...g.ch>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: Add table id from route lookup to route
 response

On 9/2/15 2:23 PM, Thomas Graf wrote:
> On 09/02/15 at 01:16pm, David Ahern wrote:
>> IPv4 ABI has the table hardcoded as RT_TABLE_MAIN regardless of the table
>> hit for the route lookup. Add the table using a new attribute,
>> RTA_TABLE_LOOKUP, to maintain the ABI yet return the right table id.
>>
>> Signed-off-by: David Ahern <dsa@...ulusnetworks.com>
>> ---
>>
>> Thomas: Something like this?
>>
>> The current ABI is returning wrong data in some cases; that seems worse
>> to me than breaking the ABI.
>
> Another option is to introduce a new flag bundled with RTM_GETROUTE
> which fixes RTM_GETROUTE altogether and makes it return the actual
> route instead of a simulated cache entry.
>

I like that better; it least then information is not duplicated. Thanks 
for the suggestion.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html