netdev - Re: [PATCH nf-next] netfilter: nf_dup{4,6}: fix build error when nf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150902.162826.1354616827708594425.davem@davemloft.net>
Date:	Wed, 02 Sep 2015 16:28:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	daniel@...earbox.net
Cc:	pablo@...filter.org, fw@...len.de, netfilter-devel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCH nf-next] netfilter: nf_dup{4,6}: fix build error when
 nf_conntrack disabled

From: Daniel Borkmann <daniel@...earbox.net>
Date: Wed,  2 Sep 2015 20:54:02 +0200

> While testing various Kconfig options on another issue, I found that
> the following one triggers as well on allmodconfig and nf_conntrack
> disabled:
> 
>   net/ipv4/netfilter/nf_dup_ipv4.c: In function ‘nf_dup_ipv4’:
>   net/ipv4/netfilter/nf_dup_ipv4.c:72:20: error: ‘nf_skb_duplicated’ undeclared (first use in this function)
>     if (this_cpu_read(nf_skb_duplicated))
>   [...]
>   net/ipv6/netfilter/nf_dup_ipv6.c: In function ‘nf_dup_ipv6’:
>   net/ipv6/netfilter/nf_dup_ipv6.c:66:20: error: ‘nf_skb_duplicated’ undeclared (first use in this function)
>     if (this_cpu_read(nf_skb_duplicated))
> 
> Fix it by including directly the header where it is defined.
> 
> Fixes: bbde9fc1824a ("netfilter: factor out packet duplication for IPv4/IPv6")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>

I'll take this directly to simplify things.

Thanks Daniel.