netdev - Re: [PATCH] flow_dissector: Use 'const' where possible.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150901.223238.302696632387058866.davem@davemloft.net>
Date:	Tue, 01 Sep 2015 22:32:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tom@...bertland.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] flow_dissector: Use 'const' where possible.

From: Tom Herbert <tom@...bertland.com>
Date: Tue, 1 Sep 2015 21:33:34 -0700

>> @@ -19,14 +19,14 @@
>>  #include <net/flow_dissector.h>
>>  #include <scsi/fc/fc_fcoe.h>
>>
>> -static bool skb_flow_dissector_uses_key(struct flow_dissector *flow_dissector,
>> -                                       enum flow_dissector_key_id key_id)
>> +static bool dissector_uses_key(const struct flow_dissector *flow_dissector,
>> +                              enum flow_dissector_key_id key_id)
>>  {
>>         return flow_dissector->used_keys & (1 << key_id);
>>  }
>>
>> -static void skb_flow_dissector_set_key(struct flow_dissector *flow_dissector,
>> -                                      enum flow_dissector_key_id key_id)
>> +static void dissector_set_key(struct flow_dissector *flow_dissector,
>> +                             enum flow_dissector_key_id key_id)
>>  {
>>         flow_dissector->used_keys |= (1 << key_id);
>>  }
>> @@ -51,20 +51,20 @@ void skb_flow_dissector_init(struct flow_dissector *flow_dissector,
> 
> I suppose we should drop skb_ from skb_flow_dissector_init and
> skb_flow_dissector_target as well.

I did it here because the functions were local and the lines would be
too long for even the first argument otherwise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html