netdev - Re: [PATCH net-next 1/1] net: fec: clear receive interrupts before processing a packet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150902094658.GO21084@n2100.arm.linux.org.uk>
Date:	Wed, 2 Sep 2015 10:46:58 +0100
From:	Russell King - ARM Linux <linux@....linux.org.uk>
To:	Philippe De Muyter <phdm@...q.eu>
Cc:	Fugang Duan <b38611@...escale.com>, davem@...emloft.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/1] net: fec: clear receive interrupts before
 processing a packet

On Wed, Sep 02, 2015 at 11:40:15AM +0200, Philippe De Muyter wrote:
> On Wed, Sep 02, 2015 at 05:24:14PM +0800, Fugang Duan wrote:
> > From: Russell King <rmk+kernel@....linux.org.uk>
> > 
> > The patch just to re-submit the patch "db3421c114cfa6326" because the
> > patch "4d494cdc92b3b9a0" remove the change.
> 
> I think you should mention also the titles of the commits.

Yes, that's standard kernel procedure.  Also, 12 characters of commit ID
is the recommended length.

> Could a comment be added here to avoid another future removal ?

I think reading the commit messages introducing the code would also help,
but a comment wouldn't hurt.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html