netdev - Re: [PATCH] net: eth: altera: fix napi poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150903.150102.391475245.nemoto@toshiba-tops.co.jp>
Date:	Thu, 3 Sep 2015 15:01:02 +0900
From:	Atsushi Nemoto <nemoto@...hiba-tops.co.jp>
To:	<davem@...emloft.net>
CC:	<vbridger@...nsource.altera.com>, <netdev@...r.kernel.org>,
	<eric.dumazet@...il.com>
Subject: Re: [PATCH] net: eth: altera: fix napi poll_list corruption

On Wed, 2 Sep 2015 22:32:54 -0700, David Miller <davem@...emloft.net> wrote:
>> I think napi_gro_flush() can be called with irq enabled, so moving the
>> spin_lock_irqsave() just before the __napi_complete() (or moving the
>> __napi_complete() just after the spin_lock_irqsave()) would be better,
>> right?
> 
> It should work, yes.

Thank you.  But I agree with Eric's last comment ("Calling
napi_gro_flush() and __napi_complete() looks error prone."), and found
that napi_complete_done() also checks NAPI_STATE_NPSVC to support
NETPOLL.  These checks looks somewhat redundant but I like simple way
unless it is really critical to performance.

So, please take original fix as is.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html