netdev - RE: [Xen-devel] [PATCH v2 net-next] xen-netback: add support for multicast control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9AAE0902D5BC7E449B7C8E4E778ABCD02F5B05DA@AMSPEX01CL01.citrite.net>
Date:	Thu, 3 Sep 2015 09:34:49 +0000
From:	Paul Durrant <Paul.Durrant@...rix.com>
To:	Ian Campbell <Ian.Campbell@...rix.com>,
	Jan Beulich <JBeulich@...e.com>
CC:	Wei Liu <wei.liu2@...rix.com>,
	"xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Xen-devel] [PATCH v2 net-next] xen-netback: add support for
 multicast control

> -----Original Message-----
> From: Ian Campbell [mailto:ian.campbell@...rix.com]
> Sent: 03 September 2015 10:31
> To: Paul Durrant; Jan Beulich
> Cc: Wei Liu; xen-devel@...ts.xenproject.org; netdev@...r.kernel.org
> Subject: Re: [Xen-devel] [PATCH v2 net-next] xen-netback: add support for
> multicast control
> 
> On Thu, 2015-09-03 at 10:00 +0100, Paul Durrant wrote:
> > >
> > > -----Original Message-----
> > > From: Jan Beulich [mailto:JBeulich@...e.com]
> > > Sent: 03 September 2015 09:57
> > > To: Paul Durrant
> > > Cc: Ian Campbell; Wei Liu; xen-devel@...ts.xenproject.org;
> > > netdev@...r.kernel.org
> > > Subject: Re: [Xen-devel] [PATCH v2 net-next] xen-netback: add support
> > > for
> > > multicast control
> > >
> > > > > > On 02.09.15 at 18:58, <paul.durrant@...rix.com> wrote:
> > > > @@ -1215,6 +1289,31 @@ static void xenvif_tx_build_gops(struct
> > > xenvif_queue *queue,
> > > >  				break;
> > > >  		}
> > > >
> > > > +		if (extras[XEN_NETIF_EXTRA_TYPE_MCAST_ADD - 1].type)
> > > > {
> > > > +			struct xen_netif_extra_info *extra;
> > > > +
> > > > +			extra =
> > > &extras[XEN_NETIF_EXTRA_TYPE_MCAST_ADD - 1];
> > > > +			ret = xenvif_mcast_add(queue->vif, extra-
> > > > u.mcast.addr);
> > >
> > > What's the reason this call isn't gated on vif->multicast_control?
> > >
> >
> > No particular reason. I guess it eats a small amount of memory for no
> > gain but a well behaved frontend wouldn't send such a request and a
> > malicious one can only send 64 of them before netback starts to reject
> > them.
> 
> Perhaps a confused guest might submit them thinking they would work
> when
> actually the feature hasn't been properly negotiated and since it would
> succeed it wouldn't generate an error on the guest side?

It would, but that's essentially harmless to functionality. If the feature had not been negotiated properly then multicast flooding would still be in operation so the guest would not lose any multicasts. I can tighten things up if you like but as you say below it is a bit of a corner case.

  Paul

> 
> (A bit of a niche corner case I confess...)