netdev - Re: [patch net] switchdev: fix return value of switchdev_port_fdb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 03 Sep 2015 09:59:38 -0700
From:	"Samudrala, Sridhar" <sridhar.samudrala@...el.com>
To:	Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org
CC:	davem@...emloft.net, idosch@...lanox.com, eladr@...lanox.com,
	sfeldma@...il.com, Jiri Pirko <jiri@...lanox.com>
Subject: Re: [patch net] switchdev: fix return value of switchdev_port_fdb_dump
 in case of error

On 9/3/2015 5:04 AM, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
>
> switchdev_port_fdb_dump is used as .ndo_fdb_dump. Its return value is
> idx, so we cannot return errval.
>
> Fixes: 45d4122ca7cd ("switchdev: add support for fdb add/del/dump via switchdev_port_obj ops.")
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
Acked-by: Sridhar Samudrala <sridhar.samudrala@...el.com>

> ---
>   net/switchdev/switchdev.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
> index 16c1c43..fda38f8 100644
> --- a/net/switchdev/switchdev.c
> +++ b/net/switchdev/switchdev.c
> @@ -853,12 +853,8 @@ int switchdev_port_fdb_dump(struct sk_buff *skb, struct netlink_callback *cb,
>   		.cb = cb,
>   		.idx = idx,
>   	};
> -	int err;
> -
> -	err = switchdev_port_obj_dump(dev, &dump.obj);
> -	if (err)
> -		return err;
>   
> +	switchdev_port_obj_dump(dev, &dump.obj);
>   	return dump.idx;
>   }
>   EXPORT_SYMBOL_GPL(switchdev_port_fdb_dump);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html