netdev - Re: [PATCH v3] net: Fix behaviour of unreachable, blackhole and prohibit routes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150903.103109.1102527875442650781.davem@davemloft.net>
Date:	Thu, 03 Sep 2015 10:31:09 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	nforro@...hat.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH v3] net: Fix behaviour of unreachable, blackhole and
 prohibit routes

From: Nikola Forró <nforro@...hat.com>
Date: Thu, 03 Sep 2015 12:05:22 +0200

> @@ -233,8 +233,11 @@ static inline int fib_lookup(struct net *net, const struct flowi4 *flp,
>  	rcu_read_lock();
>  
>  	tb = fib_get_table(net, RT_TABLE_MAIN);
> -	if (tb && !fib_table_lookup(tb, flp, res, flags | FIB_LOOKUP_NOREF))
> -		err = 0;
> +	if (tb) {
> +		err = fib_table_lookup(tb, flp, res, flags | FIB_LOOKUP_NOREF);
> +		if (err == -EAGAIN)
> +			err = -ENETUNREACH;
> +	}
>  

You resubmitted this so quickly, there is no way you did any testing
of this code path even after fixing up the curly brace issue.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html