netdev - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8BC0F5D8-5872-4387-BACA-BE7EAF479928@intel.com>
Date:	Fri, 4 Sep 2015 17:38:41 +0000
From:	"Rustad, Mark D" <mark.d.rustad@...el.com>
To:	David Laight <David.Laight@...LAB.COM>
CC:	Marcel Holtmann <marcel@...tmann.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"David S. Miller" <davem@...emloft.net>,
	Lorenzo Bianconi <lorenzo.bianconi83@...il.com>,
	"Berg, Johannes" <johannes.berg@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Network Development <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT] Networking

> On Sep 4, 2015, at 2:07 AM, David Laight <David.Laight@...LAB.COM> wrote:
> 
>> I find them useful as syntactic sugar. We have not used them a lot, but there are cases in our crypto
>> handling code where we have fixed size array inputs/outputs and there we opted to use them. They make
>> it easy to remember what the expected sizes of input and output are without having to read through the
>> implementation (of course we never even tried to use sizeof on these pointers).
>> 
>> static int smp_ah(struct crypto_blkcipher *tfm, const u8 irk[16],
>>                  const u8 r[3], u8 res[3])
> 
> Expect that it looks like you are passing arrays by value,
> but instead you are passing by reference.
> 
> Explicitly pass by reference and sizeof works.

It depends on what you mean by works. It at least doesn't look so misleading when passing by reference and so works more as expected. The sizeof in either case will never return the size of the array. To have sizeof return the size of the array would require a typedef of the array to pass by reference. In some cases that could be the right thing to do.

--
Mark Rustad, Networking Division, Intel Corporation


Download attachment "signature.asc" of type "application/pgp-signature" (842 bytes)