lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 4 Sep 2015 14:45:54 -0600 From: Tycho Andersen <tycho.andersen@...onical.com> To: Kees Cook <keescook@...omium.org> Cc: Alexei Starovoitov <ast@...nel.org>, Will Drewry <wad@...omium.org>, Oleg Nesterov <oleg@...hat.com>, Andy Lutomirski <luto@...capital.net>, Pavel Emelyanov <xemul@...allels.com>, "Serge E. Hallyn" <serge.hallyn@...ntu.com>, Daniel Borkmann <daniel@...earbox.net>, LKML <linux-kernel@...r.kernel.org>, Network Development <netdev@...r.kernel.org> Subject: Re: [PATCH 3/6] ebpf: add a way to dump an eBPF program On Fri, Sep 04, 2015 at 01:17:30PM -0700, Kees Cook wrote: > On Fri, Sep 4, 2015 at 9:04 AM, Tycho Andersen > <tycho.andersen@...onical.com> wrote: > > This commit adds a way to dump eBPF programs. The initial implementation > > doesn't support maps, and therefore only allows dumping seccomp ebpf > > programs which themselves don't currently support maps. > > > > We export the GPL bit as well as a unique ID for the program so that > > This unique ID appears to be the heap address for the prog. That's a > huge leak, and should not be done. We don't want to introduce new > kernel address leaks while we're trying to fix the remaining ones. > Shouldn't the "unique ID" be the fd itself? I imagine KCMP_FILE > could be used, for example. No; we acquire the fd per process, so if a task installs a filter and then forks N times, we'll grab N (+1) copies of the filter from N (+1) different file descriptors. Ideally, we'd have some way to figure out that these were all the same. Some sort of prog_id is one way, although there may be others. Tycho -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists