netdev - Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150904.152223.1146732101537643393.davem@davemloft.net>
Date:	Fri, 04 Sep 2015 15:22:23 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	romieu@...zoreil.com
Cc:	pomidorabelisima@...il.com, netdev@...r.kernel.org,
	vinschen@...hat.com
Subject: Re: [PATCH net 1/1] r8169: fix sleepable allocation during
 netdevice stats retrieval.

From: Francois Romieu <romieu@...zoreil.com>
Date: Fri, 4 Sep 2015 22:59:04 +0200

> net/core/net-sysfs.c::netstat_show fetches statistics under dev_base_lock.
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=104031
> Fixes: 6e85d5ad36a2 ("r8169: Add values missing in @get_stats64 from HW counters")
> Signed-off-by: Francois Romieu <romieu@...zoreil.com>
> Cc: Corinna Vinschen <vinschen@...hat.com>

Is there any reason we cannot allocate this DMA buffer at probe or
open time?

There cannot be any arguments concerning parallel access as far
as I can see, there is a single set of registers to program
this address into therefore we cannot allow more than one entity
to get into the counter fetch sequence at the same time anyways.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html