netdev - Re: [PATCH v2 1/2] ethtool: changes of emac_regs structure accordingly within driver emac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1441449673.14803.4.camel@decadent.org.uk>
Date:	Sat, 05 Sep 2015 11:41:13 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Ivan Mikhaylov <ivan@...ibm.com>, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH v2 1/2] ethtool: changes of emac_regs structure
 accordingly within driver emac_regs structure.

On Wed, 2015-08-05 at 15:01 +0400, Ivan Mikhaylov wrote:
> * do the redefinition of emac_regs struct from driver structure perspective
>   and passing size from actual struct size, not from memory area variable
>   which set in dts file.
> 
> * passing variable from dts option may cause a problem with output below 
>   MII's section which we're fixing with this and 5369c71 commit in kernel.
[...]

But you still aren't handling the case where only one of the driver and
ethtool is upgraded, even by reporting an error.

I'm never going to apply patches to ethtool that obviously break binary
compatibility, so you are wasting your time sending me new versions
that do that.

At this point you should probably just bump the dump version numbers in
both places.

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.


Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)