netdev - Re: [PATCH ethtool V3 1/2] ethtool: Add copybreak support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1441446539.13323.4.camel@decadent.org.uk>
Date:	Sat, 05 Sep 2015 10:48:59 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Hadar Hen Zion <hadarh@...lanox.com>
Cc:	netdev@...r.kernel.org, _govind@....com,
	Amir Vadai <amirv@...lanox.com>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Tal Alon <talal@...lanox.com>
Subject: Re: [PATCH ethtool V3 1/2] ethtool: Add copybreak support

On Thu, 2015-06-11 at 15:15 +0300, Hadar Hen Zion wrote:
> From: Govindarajulu Varadarajan <_govind@....com>
> 
> Add support for setting/getting driver's tx/rx_copybreak value.
> 
> Copybreak is handled through a new ethtool tunable interface.
> 
> The kernel support was added in 3.18, commit f0db9b07341 "ethtool:
> Add generic options for tunables"
[...]

So why have you sent a patch that only handles copy-break?  The kernel 
tells us the type of each tunable and ethtool should use that to decide
how to print and parse values.

Ben.

-- 
Ben Hutchings
friends: People who know you well, but like you anyway.


Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)