netdev - Re: [PATCH] net: fec: normalize return value of pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150905.220425.2069850242655969926.davem@davemloft.net>
Date:	Sat, 05 Sep 2015 22:04:25 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mail@...iej.szmigiero.name
Cc:	netdev@...r.kernel.org, B38611@...escale.com,
	Frank.Li@...escale.com, LW@...O-electronics.de,
	fabio.estevam@...escale.com, andrew@...n.ch,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: fec: normalize return value of
 pm_runtime_get_sync() in MDIO write

From: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Date: Thu, 03 Sep 2015 21:38:30 +0200

> If fec MDIO write method succeeds its return value comes from
> call to pm_runtime_get_sync().
> But pm_runtime_get_sync() can also return 1.
> 
> In case of Micrel KSZ9031 PHY this value will then
> be returned along the call chain of phy_write() ->
> ksz9031_extended_write() -> ksz9031_center_flp_timing() ->
> ksz9031_config_init() -> phy_init_hw() -> phy_attach_direct() ->
> phy_connect_direct().
> 
> Then phy_connect() will cast it into a pointer using ERR_PTR(),
> which then fec_enet_mii_probe() will try to dereference
> resulting in an oops.
> 
> Fix it by normalizing return value of pm_runtime_get_sync()
> to be zero if positive in MDIO write method.
> 
> Signed-off-by: Maciej Szmigiero <mail@...iej.szmigiero.name>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html