netdev - Re: [PATCH net 1/3] r8169: decouple the counters data and the device private area.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150906103855.GG30539@calimero.vinschen.de>
Date:	Sun, 6 Sep 2015 12:38:55 +0200
From:	Corinna Vinschen <vinschen@...hat.com>
To:	romieu@...zoreil.com
Cc:	netdev@...r.kernel.org, David Miller <davem@...emloft.net>,
	pomidorabelisima@...il.com
Subject: Re: [PATCH net 1/3] r8169: decouple the counters data and the device
 private area.

On Sep  5 14:18, romieu@...zoreil.com wrote:
> From: Francois Romieu <romieu@...zoreil.com>
> @@ -2335,24 +2337,25 @@ static void rtl8169_get_ethtool_stats(struct net_device *dev,
>  				      struct ethtool_stats *stats, u64 *data)
>  {
>  	struct rtl8169_private *tp = netdev_priv(dev);
> +	struct rtl8169_counters *c = tp->counters;

Minor style nit: Shouldn't that local var ideally be called "counters"
as you did in the other functions?


Corinna

Content of type "application/pgp-signature" skipped