netdev - Re: [PATCH] be2net: Revert "make the RX_FILTER command asynchronous" commit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150905.220139.10413461941504850.davem@davemloft.net>
Date:	Sat, 05 Sep 2015 22:01:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	sathya.perla@...gotech.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] be2net: Revert "make the RX_FILTER command
 asynchronous" commit

From: Sathya Perla <sathya.perla@...gotech.com>
Date: Thu,  3 Sep 2015 07:41:53 -0400

> The be_cmd_rx_filter() routine sends a non-embedded cmd to the FW and used
> a pre-allocated dma memory to hold the cmd payload. This worked fine when
> this cmd was synchronous. This cmd was changed to asynchronous mode by the
> commit 8af65c2f4("make the RX_FILTER command asynchronous"). So now when
> there are two quick invocations of this cmd, the 2nd request may end up
> overwriting the first request, causing FW cmd corruption.
> 
> This patch reverts the offending commit and hence fixes the regression.
> 
> Fixes: 8af65c2f4("be2net: make the RX_FILTER command asynchronous")
> Signed-off-by: Sathya Perla <sathya.perla@...gotech.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html