netdev - Re: [PATCH] lan78xx: Fix ladv/radv error handling in lan78xx_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150906.194718.1930392629598351441.davem@davemloft.net>
Date:	Sun, 06 Sep 2015 19:47:18 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	geert@...ux-m68k.org
Cc:	Woojung.Huh@...rochip.com, linux-usb@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lan78xx: Fix ladv/radv error handling in
 lan78xx_link_reset()

From: Geert Uytterhoeven <geert@...ux-m68k.org>
Date: Fri,  4 Sep 2015 12:47:28 +0200

> net/usb/lan78xx.c: In function ‘lan78xx_link_reset’:
> net/usb/lan78xx.c:1107: warning: comparison is always false due to limited range of data type
> net/usb/lan78xx.c:1111: warning: comparison is always false due to limited range of data type
> 
> Assigning return values that can be negative error codes to "u16"
> variables makes them positive, ignoring the errors.  Hence use "int"
> instead.
> 
> Drop the "unlikely"s (unlikely considered harmful) and propagate the
> actual error values instead of overriding them to -EIO while we're at
> it.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Applied, thanks.