netdev - Re: [PATCH] device property: Don't overwrite addr when failing in device_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150908.134039.343467168113066960.davem@davemloft.net>
Date:	Tue, 08 Sep 2015 13:40:39 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	julien.grall@...rix.com
Cc:	jeremy.linton@....com, linux-kernel@...r.kernel.org,
	gregkh@...uxfoundation.org, netdev@...r.kernel.org
Subject: Re: [PATCH] device property: Don't overwrite addr when failing in
 device_get_mac_address

From: Julien Grall <julien.grall@...rix.com>
Date: Thu, 3 Sep 2015 23:59:50 +0100

> The function device_get_mac_address is trying different property names
> in order to get the mac address. To check the return value, the variable
> addr (which contain the buffer pass by the caller) will be re-used. This
> means that if the previous property is not found, the next property will
> be read using a NULL buffer.
> 
> Therefore it's only possible to retrieve the mac if node contains a
> property "mac-address". Fix it by using a temporary buffer for the
> return value.
> 
> This has been introduced by commit 4c96b7dc0d393f12c17e0d81db15aa4a820a6ab3
> "Add a matching set of device_ functions for determining mac/phy"
> 
> Signed-off-by: Julien Grall <julien.grall@...rix.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html