[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 08 Sep 2015 22:28:06 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: f.fainelli@...il.com
Cc: netdev@...r.kernel.org, vivien.didelot@...oirfairelinux.com,
linux@...ck-us.net, andrew@...n.ch
Subject: Re: [PATCH net] net: dsa: bcm_sf2: Fix ageing conditions and
operation
From: Florian Fainelli <f.fainelli@...il.com>
Date: Sat, 5 Sep 2015 13:07:27 -0700
> The comparison check between cur_hw_state and hw_state is currently
> invalid because cur_hw_state is right shifted by G_MISTP_SHIFT, while
> hw_state is not, so we end-up comparing bits 2:0 with bits 7:5, which is
> going to cause an additional aging to occur. Fix this by not shifting
> cur_hw_state while reading it, but instead, mask the value with the
> appropriately shitfted bitmask.
>
> The other problem with the fast-ageing process is that we did not set
> the EN_AGE_DYNAMIC bit to request the ageing to occur for dynamically
> learned MAC addresses. Finally, write back 0 to the FAST_AGE_CTRL
> register to avoid leaving spurious bits sets from one operation to the
> other.
>
> Fixes: 12f460f23423 ("net: dsa: bcm_sf2: add HW bridging support")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> David, this dates back to 4.1, could you queue this for -stable?
Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists