netdev - Re: [PATCH net-next 1/1] net: fec: add netif status check before set mac address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 Sep 2015 14:13:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fugang.duan@...escale.com
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org,
	bhutchings@...arflare.com
Subject: Re: [PATCH net-next 1/1] net: fec: add netif status check before
 set mac address

From: Duan Andy <fugang.duan@...escale.com>
Date: Wed, 9 Sep 2015 03:45:48 +0000

> From: Florian Fainelli <f.fainelli@...il.com> Sent: Wednesday, September 09, 2015 11:38 AM
>> To: Duan Fugang-B38611; davem@...emloft.net
>> Cc: netdev@...r.kernel.org; bhutchings@...arflare.com
>> Subject: Re: [PATCH net-next 1/1] net: fec: add netif status check before
>> set mac address
>> 
>> Le 09/08/15 19:42, Fugang Duan a écrit :
>> > There exist one issue by below case that case system hang:
>> > ifconfig eth0 down
>> > ifconfig eth0 hw ether 00:10:19:19:81:19
>> >
>> > After eth0 down, all fec clocks are gated off. In the
>> > .fec_set_mac_address() function, it will set new MAC address to
>> registers, which causes system hang.
>> >
>> > So it needs to add netif status check to avoid registers access when
>> > clocks are gated off. Until eth0 up the new MAC address are wrote into
>> related registers.
>> 
>> Since this is a bug fix, do not you intend to target the "net" tree
>> instead of "net-next"?
>> 
> Thanks for your reminding, it is better to enter net tree.
> 
> David, if you apply it, pls put it into net tree. Thanks.

You need to address the feedback given by Lucas first.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html