netdev - Re: [PATCH v6 02/10] ss: created formatters for json and hr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 9 Sep 2015 15:34:40 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	Matthias Tafelmeier <matthias.tafelmeier@....net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"hagen@...u.net" <hagen@...u.net>,
	"shemminger@...l.org" <shemminger@...l.org>,
	"fw@...len.de" <fw@...len.de>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"daniel@...earbox.net" <daniel@...earbox.net>
Subject: Re: [PATCH v6 02/10] ss: created formatters for json and hr

On Wed, 9 Sep 2015 22:00:36 +0000
Matthias Tafelmeier <matthias.tafelmeier@....net> wrote:

> >> +#define STATIC_ASSERT(COND, MSG)			\
> >> +{							\
> >> +	char STATIC_ASSERT##MSG[(COND) ? 1 : -1];	\
> >> +	(void)STATIC_ASSERT##MSG[0];		\
> >> +}
> > 
> > If you are going to introduce this, please use same convention
> > as Linux kernel. ie. BUILD_BUG_ON()
> > 
> > Your code looks like it came out of some other project.
> > 
> 
> Well, but when using "BUILD_BUG_ON()" I would have to give up on having
> put out the MSG by compiler when a static issue occurs. I liked that notion.

If it won't compile, people will look at the code. The message is really
irrelevant.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html