netdev - Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice stats retrieval.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Sep 2015 02:38:13 +0200
From:	poma <pomidorabelisima@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, romieu@...zoreil.com, m8t@...di.net,
	benedikt.meurer@...x-ag.uni-siegen.de, bernhard.walle@....de,
	hscholz@...sdorf.net, frivoal@...e.org
Subject: Re: [PATCH net 1/1] r8169: fix sleepable allocation during netdevice
 stats retrieval.

On 09.09.2015 21:04, David Miller wrote:
> From: poma <pomidorabelisima@...il.com>
> Date: Wed, 9 Sep 2015 20:34:36 +0200
> 
>> [  230.110233]  [<ffffffff810218e6>] dma_generic_alloc_coherent+0x96/0x130
>> [  230.110242]  [<ffffffff81069865>] x86_swiotlb_alloc_coherent+0x25/0x50
>> [  230.110250]  [<ffffffff810215fd>] dma_alloc_attrs+0x6d/0xe0
>> [  230.110265]  [<ffffffffa002e25e>] rtl8169_map_counters+0x3e/0x70 [r8169]
>> [  230.110277]  [<ffffffffa002f674>] rtl8169_update_counters+0x64/0x140 [r8169]
>> [  230.110289]  [<ffffffffa002f8ff>] rtl8169_get_stats64+0xbf/0x130 [r8169]
>> [  230.110299]  [<ffffffff81700b74>] dev_get_stats+0x54/0x100
> 
> The patch in question removes this call to dma_alloc_coherent() so you
> aren't running a kernel which actually has the patch applied.
> 

Here is the obvious example - in use is what is patched:

$ grep MODULE_DESCRIPTION rpmbuild/BUILD/kernel-4.2.fc24/linux-4.3.0-0.rc0.git9.1.fc24.x86_64/drivers/net/ethernet/realtek/r8169.c
MODULE_DESCRIPTION("RealTek RTL-8169 Gigabit Ethernet driver patched with [PATCH v2] r8169: Fix sleeping function called during get_stats64");

$ modinfo -n r8169; modinfo -d r8169
/lib/modules/4.3.0-0.rc0.git9.1.fc24.x86_64/updates/r8169.ko
RealTek RTL-8169 Gigabit Ethernet driver patched with [PATCH v2] r8169: Fix sleeping function called during get_stats64



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html