netdev - Re: [PATCH v4] stmmac: fix check for phydev being open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150909.170806.1419774665265285481.davem@davemloft.net>
Date:	Wed, 09 Sep 2015 17:08:06 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Alexey.Brodkin@...opsys.com
Cc:	netdev@...r.kernel.org, sergei.shtylyov@...entembedded.com,
	peppe.cavallaro@...com, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org
Subject: Re: [PATCH v4] stmmac: fix check for phydev being open

From: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Date: Wed,  9 Sep 2015 18:01:08 +0300

> Current check of phydev with IS_ERR(phydev) may make not much sense
> because of_phy_connect() returns NULL on failure instead of error value.
> 
> Still for checking result of phy_connect() IS_ERR() makes perfect sense.
> 
> So let's use combined check IS_ERR_OR_NULL() that covers both cases.
> 
> Cc: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Cc: Giuseppe Cavallaro <peppe.cavallaro@...com>
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org
> Cc: David Miller <davem@...emloft.net>
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html