netdev - Re: [PATCH net] bridge: fix igmpv3 / mldv2 report parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150911.150904.2037048001164493906.davem@davemloft.net>
Date:	Fri, 11 Sep 2015 15:09:04 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	linus.luessing@...3.blue
Cc:	netdev@...r.kernel.org, stephen@...workplumber.org,
	bridge@...ts.linux-foundation.org, linux-kernel@...r.kernel.org,
	tobias.powalowski@...glemail.com
Subject: Re: [PATCH net] bridge: fix igmpv3 / mldv2 report parsing

From: Linus Lüssing <linus.luessing@...3.blue>
Date: Fri, 11 Sep 2015 18:39:48 +0200

> With the newly introduced helper functions the skb pulling is hidden in
> the checksumming function - and undone before returning to the caller.
> 
> The IGMPv3 and MLDv2 report parsing functions in the bridge still
> assumed that the skb is pointing to the beginning of the IGMP/MLD
> message while it is now kept at the beginning of the IPv4/6 header,
> breaking the message parsing and creating packet loss.
> 
> Fixing this by taking the offset between IP and IGMP/MLD header into
> account, too.
> 
> Fixes: 9afd85c9e455 ("net: Export IGMP/MLD message validation code")
> Reported-by: Tobias Powalowski <tobias.powalowski@...glemail.com>
> Tested-by: Tobias Powalowski <tobias.powalowski@...glemail.com>
> Signed-off-by: Linus Lüssing <linus.luessing@...3.blue>

There were many serious regressions introduced by that commit, I'm
extremely disappointed.

Patch applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html