netdev - Re: [PATCH] xfrm6: Fix ICMPv6 and MH header checks in _decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150914115212.GJ25499@secunet.com>
Date:	Mon, 14 Sep 2015 13:52:12 +0200
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Mathias Krause <minipli@...glemail.com>
CC:	Herbert Xu <herbert@...dor.apana.org.au>,
	"David S. Miller" <davem@...emloft.net>,
	Marcin Jurkowski <marcin1j@...il.com>, <satmd@...n.at>,
	<netdev@...r.kernel.org>,
	Mathias Krause <mathias.krause@...unet.com>,
	PaX Team <pageexec@...email.hu>
Subject: Re: [PATCH] xfrm6: Fix ICMPv6 and MH header checks in
 _decode_session6

On Fri, Sep 11, 2015 at 09:57:20AM +0200, Mathias Krause wrote:
> From: Mathias Krause <mathias.krause@...unet.com>
> 
> Ensure there's enough data left prior calling pskb_may_pull(). If
> skb->data was already advanced, we'll call pskb_may_pull() with a
> negative value converted to unsigned int -- leading to a huge
> positive value. That won't matter in practice as pskb_may_pull()
> will likely fail in this case, but it leads to underflow reports on
> kernels handling such kind of over-/underflows, e.g. a PaX enabled
> kernel instrumented with the size_overflow plugin.
> 
> Reported-by: satmd <satmd@...n.at>
> Reported-and-tested-by: Marcin Jurkowski <marcin1j@...il.com>
> Signed-off-by: Mathias Krause <mathias.krause@...unet.com>
> Cc: PaX Team <pageexec@...email.hu>

Skipping upper layer informations due to a wrong length calculation,
may also leed to incorrect policy lookups. Patch applied to the
ipsec tree, thanks!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html