netdev - Re: [PATCH 3/5] lan78xx: update to use phylib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150915.144638.155213100283923532.davem@davemloft.net>
Date:	Tue, 15 Sep 2015 14:46:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	Woojung.Huh@...rochip.com
Cc:	f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [PATCH 3/5] lan78xx: update to use phylib

From: <Woojung.Huh@...rochip.com>
Date: Thu, 10 Sep 2015 22:16:11 +0000

> @@ -1287,42 +1074,30 @@ static int lan78xx_set_wol(struct net_device *netdev,
>  static int lan78xx_get_eee(struct net_device *net, struct ethtool_eee *edata)
>  {
>  	struct lan78xx_net *dev = netdev_priv(net);
> +	struct phy_device *phydev = net->phydev;
>  	int ret;
>  	u32 buf;
> -	u32 adv, lpadv;
>  
>  	ret = usb_autopm_get_interface(dev->intf);
>  	if (ret < 0)
>  		return ret;
>  
> +	ret = phy_ethtool_get_eee(phydev, edata);
> +	if (ret)
> +		return ret;
> +

You cannot return directly if phy_ethtool_get_eee() returns an error,
you must branch to the end of this function and properly perform
the usb_autopm_get_interface().
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html