netdev - Re: [PATCH v3 net 0/5] ipv6: Fix dst_entry refcnt bugs in ip6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150914.195637.558611773755031925.davem@davemloft.net>
Date:	Mon, 14 Sep 2015 19:56:37 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kafai@...com
Cc:	netdev@...r.kernel.org, eric.dumazet@...il.com,
	hannes@...essinduktion.org, kernel-team@...com
Subject: Re: [PATCH v3 net 0/5] ipv6: Fix dst_entry refcnt bugs in
 ip6_tunnel

From: David Miller <davem@...emloft.net>
Date: Mon, 14 Sep 2015 19:49:25 -0700 (PDT)

> Series applied, thanks Martin.

Actually, reverted, this doesn't even compile :-/

In file included from include/linux/srcu.h:33:0,
                 from include/linux/notifier.h:15,
                 from include/linux/memory_hotplug.h:6,
                 from include/linux/mmzone.h:812,
                 from include/linux/gfp.h:5,
                 from include/linux/kmod.h:22,
                 from include/linux/module.h:13,
                 from net/ipv6/ip6_tunnel.c:23:
net/ipv6/ip6_tunnel.c: In function ‘ip6_tnl_per_cpu_dst_set’:
net/ipv6/ip6_tunnel.c:135:35: error: invalid type argument of ‘->’ (have ‘seqlock_t’)
        lockdep_is_held(&idst->lock->lock)));
                                   ^
include/linux/rcupdate.h:569:52: note: in definition of macro ‘RCU_LOCKDEP_WARN’
   if (debug_lockdep_rcu_enabled() && !__warned && (c)) { \
                                                    ^
include/linux/rcupdate.h:787:2: note: in expansion of macro ‘__rcu_dereference_protected’
  __rcu_dereference_protected((p), (c), __rcu)
  ^
net/ipv6/ip6_tunnel.c:133:14: note: in expansion of macro ‘rcu_dereference_protected’
  dst_release(rcu_dereference_protected(
              ^
net/ipv6/ip6_tunnel.c:135:8: note: in expansion of macro ‘lockdep_is_held’
        lockdep_is_held(&idst->lock->lock)));
        ^