netdev - Re: [PATCH] Net: core: sock.c coding style fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150915184346.GA7817@Alexeis-MacBook-Pro-2.local>
Date:	Tue, 15 Sep 2015 11:43:49 -0700
From:	Alexei Starovoitov <alexei.starovoitov@...il.com>
To:	Krzysztof Majzerowicz-Jaszcz <cristos@...serv.org>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>, davem@...emloft.net,
	edumazet@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] Net: core: sock.c coding style fixes

On Tue, Sep 15, 2015 at 08:36:29PM +0200, Krzysztof Majzerowicz-Jaszcz wrote:
> OK, sorry. I'll undo the comments then. Do you have any other suggestions?
> 
> KMJ
> 
> On 15/09/15 20:22, Eric W. Biederman wrote:
> > Krzysztof Majzerowicz-Jaszcz <cristos@...serv.org> writes:
> > 
> >> Fixed most coding style issues reported by checkpatch.pl
> > 
> > Ugh.  At least in the matter of comments I find this patch makes
> > the code uglier.
> > 
> > Replacing:
> > /*
> >  *             Important banner about the code
> >  */
> > 
> > with
> >  /* Important banner about the code */
> > 
> > Does not look as nice and does not convey the same information as
> > clearly.
> > 
> > Remember checkpatch.pl is not the ruler or the rules it is a servant
> > with a bunch of heuristics to point out problems.
> > 
> > Eric
> > 
> >> Signed-off-by: Krzysztof Majzerowicz-Jaszcz <cristos@...serv.org>
> >> ---
> >>  net/core/sock.c | 442 +++++++++++++++++++++++++-------------------------------
> >>  1 file changed, 200 insertions(+), 242 deletions(-)

200 checkpatch changes in one commit?

imo it makes sense to fix coding style only if nearby lines are
affected by meaningful changes.
Just blank rewrites like these are more harmful than useful.
They distort git blame, make backporting harder, etc.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html