netdev - Re: [PATCH] mv643xx_eth: Neaten mv643xx_eth_program_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150915.124932.2021612592296257940.davem@davemloft.net>
Date:	Tue, 15 Sep 2015 12:49:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	linux@...musvillemoes.dk, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, sebastian.hesselbarth@...il.com
Subject: Re: [PATCH] mv643xx_eth: Neaten
 mv643xx_eth_program_multicast_filter

From: Joe Perches <joe@...ches.com>
Date: Wed, 09 Sep 2015 17:40:56 -0700

> The code around the allocation and loops are a bit obfuscated.
> 
> Neaten it by using:
> 
> o kcalloc with decimal count and sizeof(u32)
> o Decimal loop indexing and i++ not i += 4
> o A promiscuous block using a similar style
>   to the multicast block
> o Remove unnecessary variables
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html