netdev - Re: [net-next:master 6/10] include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20150915.132538.2065465403874989751.davem@davemloft.net>
Date:	Tue, 15 Sep 2015 13:25:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	fengguang.wu@...el.com
Cc:	oneukum@...e.com, kbuild-all@...org, netdev@...r.kernel.org
Subject: Re: [net-next:master 6/10] include/linux/usb/cdc.h:47:5: warning:
 'struct usb_interface' declared inside parameter list

From: kbuild test robot <fengguang.wu@...el.com>
Date: Wed, 16 Sep 2015 03:56:14 +0800

> All warnings (new ones prefixed by >>):
> 
>    In file included from drivers/usb/gadget/function/u_serial.h:16:0,
>                     from drivers/usb/gadget/function/f_acm.c:23:
>>> include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list
>         int buflen);
>         ^
>>> include/linux/usb/cdc.h:47:5: warning: its scope is only this definition or declaration, which is probably not what you want

I'll fix this as follows:

====================
[PATCH] cdc: Fix build warning.

   In file included from drivers/usb/gadget/function/u_serial.h:16:0,
                    from drivers/usb/gadget/function/f_acm.c:23:
>> include/linux/usb/cdc.h:47:5: warning: 'struct usb_interface' declared inside parameter list
        int buflen);
        ^
>> include/linux/usb/cdc.h:47:5: warning: its scope is only this definition or declaration, which is probably not what you want

Reported-by: kbuild test robot <fengguang.wu@...el.com>
Signed-off-by: David S. Miller <davem@...emloft.net>
---
 include/linux/usb/cdc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/usb/cdc.h b/include/linux/usb/cdc.h
index cd8f2e1..959d0c8 100644
--- a/include/linux/usb/cdc.h
+++ b/include/linux/usb/cdc.h
@@ -40,7 +40,7 @@ struct usb_cdc_parsed_header {
 	bool phonet_magic_present;
 };
 
-
+struct usb_interface;
 int cdc_parse_cdc_header(struct usb_cdc_parsed_header *hdr,
 				struct usb_interface *intf,
 				u8 *buffer,
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html