netdev - Re: [PATCH RFC] solos-pci: Fix BUG() with shared skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f3c01599888e375610e85d20ad3e7ab16b00ba2@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid>
Date:	Wed, 16 Sep 2015 12:32:06 +0100
From:	"Simon Arlott" <simon@...e.lp0.eu>
To:	"David Woodhouse" <dwmw2@...radead.org>
Cc:	netdev@...r.kernel.org, linux-atm-general@...ts.sourceforge.net
Subject: Re: [PATCH RFC] solos-pci: Fix BUG() with shared skb

On Tue, September 15, 2015 20:10, David Woodhouse wrote:
> On Wed, 2013-09-04 at 21:41 +0100, David Woodhouse wrote:
>> +++ b/drivers/atm/solos-pci.c
>> @@ -1145,19 +1145,19 @@ static int psend(struct atm_vcc *vcc, struct sk_buff *skb)
>> +> 	> if (skb_headroom(skb) < sizeof(*header)) {
>> +> 	> 	> struct sk_buff *nskb;
>> +
>> +> 	> 	> nskb = skb_realloc_headroom(skb, sizeof(*header));
>> +> 	> 	> if (!nskb) {
>> +> 	> 	> 	> solos_pop(vcc, skb);
>> +> 	> 	> 	> return -ENOMEM;
>> +> 	> 	> }
>> +> 	> 	> if (skb->truesize != nskb->truesize)
>> +> 	> 	> 	> atm_force_charge(vcc, nskb->truesize - skb->truesize);
>> +
>> +> 	> 	> dev_kfree_skb_any(skb);
>> +> 	> 	> skb = nskb;
>>  > 	> }
>
> Simon, did you ever test this?
> Can you still (tell me how to) reproduce the original problem? I think
> that sending on br2684 was necessary but not sufficient...?

I'm currently using this but without the call to atm_force_charge().

I don't know how to reproduce the BUG() but it hasn't happened again.

-- 
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html