lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 16 Sep 2015 21:06:58 +0800 From: Fengguang Wu <fengguang.wu@...el.com> To: David Miller <davem@...emloft.net> Cc: oneukum@...e.com, kbuild-all@...org, netdev@...r.kernel.org Subject: Re: [net-next:master 6/12] include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header' On Tue, Sep 15, 2015 at 01:27:42PM -0700, David Miller wrote: > From: kbuild test robot <fengguang.wu@...el.com> > Date: Wed, 16 Sep 2015 03:57:11 +0800 > > > All error/warnings (new ones prefixed by >>): > > > > In file included from drivers/usb/gadget/function/u_ether.h:20, > > from drivers/usb/gadget/legacy/cdc2.c:16: > > include/linux/usb/cdc.h:47: warning: 'struct usb_interface' declared inside parameter list > > include/linux/usb/cdc.h:47: warning: its scope is only this definition or declaration, which is probably not what you want > > In file included from drivers/usb/gadget/function/u_serial.h:16, > > from drivers/usb/gadget/legacy/cdc2.c:17: > >>> include/linux/usb/cdc.h:23: error: redefinition of 'struct usb_cdc_parsed_header' > > include/linux/usb/cdc.h:47: warning: 'struct usb_interface' declared inside parameter list > >>> include/linux/usb/cdc.h:47: error: conflicting types for 'cdc_parse_cdc_header' > > include/linux/usb/cdc.h:47: error: previous declaration of 'cdc_parse_cdc_header' was here > > This may be a side effect of the initial warning, does this reproduce with > that fixed? Please show me what the warning looks like in that case. Dave, net-next/master commit ad1e7b97b3 ("cdc: Fix build warning.") still has errors. The problem is, the header file <linux/usb/cdc.h> is included twice. recent_errors ├── arm-arm5 │ ├── include-linux-usb-cdc.h:error:conflicting-types-for-cdc_parse_cdc_header │ └── include-linux-usb-cdc.h:error:redefinition-of-struct-usb_cdc_parsed_header ├── arm-arm67 │ ├── include-linux-usb-cdc.h:error:conflicting-types-for-cdc_parse_cdc_header │ └── include-linux-usb-cdc.h:error:redefinition-of-struct-usb_cdc_parsed_header ├── arm-mmp │ ├── include-linux-usb-cdc.h:error:conflicting-types-for-cdc_parse_cdc_header │ └── include-linux-usb-cdc.h:error:redefinition-of-struct-usb_cdc_parsed_header ├── arm-omap2plus_defconfig │ ├── include-linux-usb-cdc.h:error:conflicting-types-for-cdc_parse_cdc_header │ └── include-linux-usb-cdc.h:error:redefinition-of-struct-usb_cdc_parsed_header ├── avr32-atngw100_defconfig │ └── include-linux-usb-cdc.h:error:redefinition-of-struct-usb_cdc_parsed_header ├── avr32-atstk1006_defconfig │ └── include-linux-usb-cdc.h:error:redefinition-of-struct-usb_cdc_parsed_header └── i386-allmodconfig ├── include-linux-usb-cdc.h:error:conflicting-types-for-cdc_parse_cdc_header └── include-linux-usb-cdc.h:error:redefinition-of-struct-usb_cdc_parsed_header The error messages are now: In file included from drivers/usb/gadget/function/u_ether.h:20:0, from drivers/usb/gadget/function/f_ncm.c:26: include/linux/usb/cdc.h:23:8: error: redefinition of 'struct usb_cdc_parsed_header' struct usb_cdc_parsed_header { ^ In file included from drivers/usb/gadget/function/f_ncm.c:24:0: include/linux/usb/cdc.h:23:8: note: originally defined here struct usb_cdc_parsed_header { ^ In file included from drivers/usb/gadget/function/u_ether.h:20:0, from drivers/usb/gadget/function/f_ncm.c:26: include/linux/usb/cdc.h:44:5: error: conflicting types for 'cdc_parse_cdc_header' int cdc_parse_cdc_header(struct usb_cdc_parsed_header *hdr, ^ In file included from drivers/usb/gadget/function/f_ncm.c:24:0: include/linux/usb/cdc.h:44:5: note: previous declaration of 'cdc_parse_cdc_header' was here int cdc_parse_cdc_header(struct usb_cdc_parsed_header *hdr, ^ Thanks, Fengguang -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists