netdev - Re: [PATCH 2/2] airo: Implement netif_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55F97CFE.3020806@cogentembedded.com>
Date:	Wed, 16 Sep 2015 17:30:22 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Ondrej Zary <linux@...nbow-software.org>,
	Dan Williams <dcbw@...hat.com>
Cc:	netdev@...r.kernel.org,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] airo: Implement netif_carrier_on/off

Hello.

On 9/15/2015 6:18 PM, Ondrej Zary wrote:

> Add calls to netif_carrier_on and netif_carrier_off
>
> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>
> ---
>   drivers/net/wireless/airo.c |    6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
> index a8f2767..629245c 100644
> --- a/drivers/net/wireless/airo.c
> +++ b/drivers/net/wireless/airo.c
[...]
> @@ -3277,7 +3278,9 @@ static void airo_handle_link(struct airo_info *ai)
>   		eth_zero_addr(wrqu.ap_addr.sa_data);
>   		wrqu.ap_addr.sa_family = ARPHRD_ETHER;
>   		wireless_send_event(ai->dev, SIOCGIWAP, &wrqu, NULL);
> -	}
> +		netif_carrier_off(ai->dev);
> +	} else
> +		netif_carrier_off(ai->dev);

    Need {} in all branches, according the the Documentation/CodingStyle.

>   }
>
>   static void airo_handle_rx(struct airo_info *ai)
[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html