netdev - Re: [PATCH net-next] net: Initialize table in fib result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55F9930E.5060305@cumulusnetworks.com>
Date:	Wed, 16 Sep 2015 10:04:30 -0600
From:	David Ahern <dsa@...ulusnetworks.com>
To:	Nikolay Aleksandrov <nikolay@...ulusnetworks.com>,
	David Ahern <dsa@...ulusnetworks.com>, netdev@...r.kernel.org
Cc:	sergey.senozhatsky.work@...il.com, richard.alpe@...csson.com,
	festevam@...il.com
Subject: Re: [PATCH net-next] net: Initialize table in fib result

On 9/16/15 9:56 AM, Nikolay Aleksandrov wrote:
> Just to have it documented: I don't think we need the second NULLing,
> but it doesn't hurt.

I think we do. After the second one there is a goto to local_input which 
uses res.table. The second goto is reachable 'if 
!IN_DEV_FORWARD(in_dev)' in which case res.table is valid but should not 
be. In short if fi is reset, table should be.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html